-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rds_param_group: fix tests, check_mode, AWSRetry #532
Merged
tremble
merged 4 commits into
ansible-collections:main
from
alinabuzachis:rds_param_group
Apr 7, 2021
Merged
rds_param_group: fix tests, check_mode, AWSRetry #532
tremble
merged 4 commits into
ansible-collections:main
from
alinabuzachis:rds_param_group
Apr 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add AWSRetry * Add check_mode
Signed-off-by: Alina Buzachis <[email protected]>
ansibullbot
added
bug
This issue/PR relates to a bug
community_review
integration
tests/integration
module
module
needs_triage
plugins
plugin (any type)
tests
tests
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR
and removed
community_review
labels
Apr 7, 2021
tremble
requested changes
Apr 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor niggle (assuming the tests pass)
Signed-off-by: Alina Buzachis <[email protected]>
tremble
approved these changes
Apr 7, 2021
tremble
reviewed
Apr 7, 2021
alinabuzachis
added a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…#532) * * Fix integration tests * Add AWSRetry * Add check_mode * Add changelog fragment Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
added a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…#532) * * Fix integration tests * Add AWSRetry * Add check_mode * Add changelog fragment Signed-off-by: Alina Buzachis <[email protected]>
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
…#532) * * Fix integration tests * Add AWSRetry * Add check_mode * Add changelog fragment Signed-off-by: Alina Buzachis <[email protected]>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…#532) * * Fix integration tests * Add AWSRetry * Add check_mode * Add changelog fragment Signed-off-by: Alina Buzachis <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@579f8de
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
This issue/PR relates to a bug
integration
tests/integration
module
module
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR
needs_triage
plugins
plugin (any type)
tests
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
rds_param_group